feat: add full ESM support #125
Conversation
| @@ -67,7 +67,7 @@ | |||
| "scripts": { | |||
| "bootstrap": "yarn --network-timeout 100000 && yarn --cwd www --network-timeout 100000", | |||
| "build": "rimraf lib && yarn build:esm && yarn build:cjs && yarn build:popper", | |||
| "build:esm": "babel src --out-dir lib --delete-dir-on-start --extensions .ts,.tsx --ignore '**/*.d.ts' && yarn build:esm:types", | |||
| "build:esm": "babel src --out-dir lib --delete-dir-on-start --extensions .ts,.tsx --ignore '**/*.d.ts' && yarn build:esm:types && echo '{\"type\": \"module\"}' > lib/package.json", | |||
There was a problem hiding this comment.
maybe just add the type: module to the root package.json?
| @@ -4,5 +4,8 @@ module.exports = (api) => ({ | |||
| ['@babel/react', { runtime: 'automatic' }], | |||
| '@babel/preset-typescript', | |||
| ], | |||
| plugins: [api.env() === 'test' && 'istanbul'].filter(Boolean), | |||
| plugins: [ | |||
| 'babel-plugin-add-import-extension', | |||
There was a problem hiding this comment.
I think the safer approach here would be to not add this, and switch tsconfig to moduleResolution: 'NodeNext' which will require extensions in the source. You get more validation from the TS compiler that it's correct.
There was a problem hiding this comment.
I am unsure whether that is compatible with also outputting a CJS build though, but it should be?
There was a problem hiding this comment.
I tried this initially, but had difficulties in getting docusaurus to resolve the paths with the ".js" extension and not breaking hot reload. There might be better support for TS in docusaurus v3, but that's another large exercise 😅
babel-plugin-add-import-extensionto add.jsextensions to sourcetype=modulepackage.json in lib folderdom-helpersto v6